Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verif.bmc VerifToSMT lowering #7603

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Add verif.bmc VerifToSMT lowering #7603

merged 11 commits into from
Sep 24, 2024

Conversation

TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Sep 16, 2024

This PR adds a pattern to lower the verif.bmc op into the program to actually perform the check (from the splitting up of #7259 - only the actual tool left after this!), similarly to what circt-lec currently does.

Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks a lot!

lib/Conversion/VerifToSMT/CMakeLists.txt Show resolved Hide resolved
lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
lib/Conversion/VerifToSMT/VerifToSMT.cpp Show resolved Hide resolved
@TaoBi22
Copy link
Contributor Author

TaoBi22 commented Sep 17, 2024

@maerhart I think that should be all comments addressed - if you could take a quick scan over the added assertion count checker that would be great!

Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
lib/Conversion/VerifToSMT/VerifToSMT.cpp Outdated Show resolved Hide resolved
@TaoBi22
Copy link
Contributor Author

TaoBi22 commented Sep 23, 2024

@maerhart as discussed offline, assertion check now conducted outside pattern - are you happy for me to hit merge?

@TaoBi22 TaoBi22 merged commit c601695 into llvm:main Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants