[FIRRTL] Make IMCP work with Layers #7598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change IMCP's module update to use a walk instead of only visiting top-level ops. This is intended to be an entirely mechanical change and is broken out in a separate commit because of its mechanical nature. Signed-off-by: Schuyler Eldridge <[email protected]>
Change IMCP to recurse into layers. This has the effect of allowing IMCP to sink constants into layers and to properly visit instances which are instantiated under layers. Signed-off-by: Schuyler Eldridge <[email protected]>
dtzSiFive
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change IMCP's module update to use a walk instead of only visiting
top-level ops. This is intended to be an entirely mechanical change and
is broken out in a separate commit because of its mechanical nature.
Change IMCP to recurse into layers. This has the effect of allowing IMCP
to sink constants into layers and to properly visit instances which are
instantiated under layers.