Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM bump to include upstream verifier performance fix. #7496

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

dtzSiFive
Copy link
Contributor

@maerhart
Copy link
Member

maerhart commented Aug 9, 2024

Seems some LLHD things are breaking. I hope this should do the trick:

diff --git a/include/circt/Dialect/HW/HWTypes.td b/include/circt/Dialect/HW/HWTypes.td
index f2f8c1c8b..26e8cc39b 100644
--- a/include/circt/Dialect/HW/HWTypes.td
+++ b/include/circt/Dialect/HW/HWTypes.td
@@ -39,7 +39,7 @@ def HWNonInOutType : DialectType<HWDialect,
 
 def InOutType : DialectType<HWDialect,
     CPred<"::circt::hw::type_isa<circt::hw::InOutType>($_self)">,
-          "InOutType", "InOutType">;
+          "InOutType", "::circt::hw::TypeAliasOr<circt::hw::InOutType>">;
 
 class InOutTypeOf<list<Type> allowedTypes>
   : ContainerType<AnyTypeOf<allowedTypes>, CPred<"::circt::hw::type_isa<::circt::hw::InOutType>($_self)">,

@dtzSiFive
Copy link
Contributor Author

Seems some LLHD things are breaking. I hope this should do the trick:

Thanks!! Looks like that's what was needed! 👍

@seldridge seldridge merged commit b3a54e3 into main Aug 9, 2024
4 checks passed
@seldridge seldridge deleted the update/llvm-2024-08-09 branch August 9, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants