[Moore] Add FVIntegerAttr #7461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
requested review from
mikeurbach,
uenoku,
maerhart and
hailongSun2000
Add the `FVIntegerAttr`, an attribute containing an `FVInt` value. This
allows four-valued integer constants to be used as attributes on
operations and for constant folding to occur on such values. In contrast
to the builtin `IntegerAttr`, `FVIntegerAttr` does not have a type yet.
The type can be added later as soon as we have a concrete use case.
I expect us to eventually move `FVIntegerAttr` into the HW dialect once
we are happy with its design. Other parts of CIRCT will eventually want
to reason about four-valued integers as well.
The parsing and printing of the attribute tries to make the `FVInt` read
like a plain old `APInt` when there are no X or Z bits present.
Otherwise it falls back to printing as hexadecimal or binary number.
To distinguish the different representations and to allow constants with
X or Z to be parsed as keywords, a `h` and `b` prefix is used for the
hexadecimal and binary formatting, respectively.
Examples of the attribute:
#moore.fvint<42 : 32>
#moore.fvint<-42 : 32>
#moore.fvint<1234567890123456789012345678901234567890 : 131>
#moore.fvint<hABCDEFXZ0123456789 : 72>
#moore.fvint<b1010XZ01 : 8>
fabianschuiki
force-pushed
the
fschuiki/FVIntegerAttr
branch
from
e3e17a1
to
67009e2
Compare
mikeurbach
approved these changes
Aug 8, 2024
hailongSun2000
approved these changes
Aug 8, 2024
|
Thanks for the reviews 😃 Going to land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
FVIntegerAttr, an attribute containing anFVIntvalue. This allows four-valued integer constants to be used as attributes on operations and for constant folding to occur on such values. In contrast to the builtinIntegerAttr,FVIntegerAttrdoes not have a type yet. The type can be added later as soon as we have a concrete use case.I expect us to eventually move
FVIntegerAttrinto the HW dialect once we are happy with its design. Other parts of CIRCT will eventually want to reason about four-valued integers as well.The parsing and printing of the attribute tries to make the
FVIntread like a plain oldAPIntwhen there are no X or Z bits present. Otherwise it falls back to printing as hexadecimal or binary number. To distinguish the different representations and to allow constants with X or Z to be parsed as keywords, ahandbprefix is used for the hexadecimal and binary formatting, respectively.Examples of the attribute: