Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HWArith] Make hwarith.icmp result an i1 #7413

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

teqdruid
Copy link
Contributor

As discussed in #7406. Resolves #7406.

@teqdruid teqdruid added the HWArith The `hwarith` dialect label Jul 31, 2024
@teqdruid teqdruid requested a review from mortbopet as a code owner July 31, 2024 12:41
@teqdruid teqdruid requested a review from jopperm July 31, 2024 12:42
docs/Dialects/HWArith/RationaleHWArith.md Outdated Show resolved Hide resolved
include/circt/Dialect/HWArith/HWArithOps.td Outdated Show resolved Hide resolved
@teqdruid teqdruid merged commit 562036c into main Aug 9, 2024
4 checks passed
@teqdruid teqdruid deleted the teqdruid/hwarith/icmp-i1 branch August 9, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HWArith The `hwarith` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hwarith] Shouldn't ICmpOp result be i1?
3 participants