Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add cmake flags that reduce memory usage #7018

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

dobios
Copy link
Member

@dobios dobios commented May 9, 2024

This PR introduces some additional cmake flags to the GettingStarted docs that help reduce memory usage.

@dobios dobios added the documentation Improvements or additions to documentation label May 9, 2024
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Comment on lines 272 to 285
If you have commit access, you can do this yourself, otherwise a reviewer can do it for you.
If you have commit access, you can do this yourself, otherwise a reviewer can do it for you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray whitespace 🧐

In order to use the recommended `lld` linker, use the `-DLLVM_ENABLE_LLD=ON`.
Removing that flag will use your compiler's default linker. More details about
these problems and their solutions can be found
[in the llvm docs](https://llvm.org/docs/GettingStarted.html#common-problems).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[in the llvm docs](https://llvm.org/docs/GettingStarted.html#common-problems).
[in the LLVM docs](https://llvm.org/docs/GettingStarted.html#common-problems).

Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fabian's comments excepted, this looks gtg!

@dobios dobios merged commit 12c44ad into main May 9, 2024
2 checks passed
@dobios dobios deleted the docs/dobios/cmake-flags branch May 9, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants