Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiring problem error with const source and non-const sink w/no-ref-type option #6819

Closed
dtzSiFive opened this issue Mar 13, 2024 · 0 comments · Fixed by #6822
Closed

Wiring problem error with const source and non-const sink w/no-ref-type option #6819

dtzSiFive opened this issue Mar 13, 2024 · 0 comments · Fixed by #6822
Labels
bug Something isn't working FIRRTL Involving the `firrtl` dialect

Comments

@dtzSiFive
Copy link
Contributor

Consider:

FIRRTL version 4.0.0

circuit ZW: %[[
  {
    "class": "sifive.enterprise.grandcentral.DataTapsAnnotation",
    "keys": [
      {
        "class": "sifive.enterprise.grandcentral.ReferenceDataTapKey",
        "source": "~ZW|ZW>in",
        "sink": "~ZW|ZW/c:Child>sink"
      }
    ]
  }
]]
  module Child:
    wire sink : UInt<0>
    invalidate sink
 

  public module ZW:
    input in : const UInt<0>

    inst c of Child

Built with firtool --lower-annotations-no-ref-type-ports this produces an error:

tap_zw_const.fir:21:11: error: Wiring Problem source type '!firrtl.const.uint<0>' does not match sink type '!firrtl.uint<0>'
    input in : const UInt<0>
          ^
tap_zw_const.fir:16:5: note: The sink is here.
    wire sink : UInt<0>
    ^

cc #4651.

@dtzSiFive dtzSiFive added bug Something isn't working FIRRTL Involving the `firrtl` dialect labels Mar 13, 2024
dtzSiFive added a commit to dtzSiFive/circt that referenced this issue Mar 13, 2024
Add test as "legacy wiring" as non-ref-type-port path is a hidden option.

Compatibility dest/source operands were backwards,
introduced in llvm#4656 .

Fixes llvm#6819.
dtzSiFive added a commit to dtzSiFive/circt that referenced this issue Mar 13, 2024
Add test as "legacy wiring" as non-ref-type-port path is a hidden option.

Compatibility dest/source operands were backwards,
introduced in llvm#4656 .

Fixes llvm#6819.
dtzSiFive added a commit that referenced this issue Mar 14, 2024
Compatibility dest/source operands were backwards,
introduced in #4656 .

Add test as "legacy wiring" as non-ref-type-port path is a hidden option.

Fixes #6819.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant