Fixed memory leak issue in Ubuntu 22.04 or modern linux environment #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw the PR in A1111 is merged. I am going to close this PR, and pull the change from A1111 upstream. (If I merge the PR, there will be merge conflict when we pull the same change from upstream.) |
|
Hmm, I understand.😿 |
4 tasks
|
Good news: thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where tcmalloc was not preloaded on recent Linux such as ubuntu 22.04, causing a memory leak.
This is because on modern linux libpthread is integrated into libc.so. and there is a problem with the tcmalloc search logic in webui.sh.
This merge checks the lib version in advance and sets tcmalloc to LD_PRELOAD appropriately.
see also -->
AUTOMATIC1111/stable-diffusion-webui#14227
(I think this merge is wrong....)
Screenshots/videos:
Checklist: