-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged some MRE features (generate hotkey, generate forever, notification sound) #702
Merged some MRE features (generate hotkey, generate forever, notification sound) #702
Conversation
@lllyasviel Please check if it's OK to be merged - set of non-intrusive features ported from A1111:
|
stop button does not stop generating forever - a bit bad |
if u do not know how to let python gradio to stop the forever loop at js level, I can take a look later |
That's how it originally worked in A1111 (separate starting and stopping single and forever generation), so I just left it this way. But you might be right it could be more intuitive if Stop simply stopped all generation, no matter how it was started. Maybe merge as it is, and then simplify stopping generation in another commit? |
@lllyasviel Stopping simplified. |
also i am not hearing the notification sound. |
@lllyasviel Yes, by default it's not played - I provided example notification file as |
And context menu removed from stop button - you're right it didn't make much sense. |
cool, then add version by 1, and merge yourself after that. |
Merged some non-intrusive Fooocus-MRE features (generate hotkey, generate forever, notification sound - ported from A1111).