load plugins from additive directories #222
Conversation
bin/limbo
Outdated
| help="The path where limbo should look to find its plugins") | ||
| help=("The primary path where limbo should look to find its plugins. Setting this " | ||
| "will override the default list of plugins.")) | ||
| parser.add_argument('--extrapluginpaths', '-epp', dest='extrapluginpaths', default=[], |
There was a problem hiding this comment.
Could we just modify --pluginpath to accept multiple instances instead of adding a new flag?
There was a problem hiding this comment.
I put some suggestions in a branch llimllib-suggestions. Here's the diff: appleshampooid/limbo@appleshampooid_additive_plugins...llimllib:limbo:llimllib-suggestions
How do they look to you?
There was a problem hiding this comment.
Could we just modify
--pluginpathto accept multiple instances instead of adding a new flag?
I generally like this idea better, other than the somewhat-clunky nature of including the default plugins along with your custom ones (see my updated PR description for an example).
Let me know what you think? Could also include the default plugins by default, all the time, and then maybe an extra param to remove them? Shrug.
|
Apologies for the super slow review! |
No problem at all, I understand this is not anyone's full time job. Taking a look at your suggestions this weekend! |
Addresses #221 with an extension to the --pluginpath argument.
If one wishes to add some plugins, and keep the original, you will have to invoke it with two -p arguments: your custom plugins, and then a path to the default plugin dir. e.g.:
Happy to accept feedback and constructive criticism. I am not an experienced pythonista 😂