Fix typo in RenderService (yewstack#658)

llebout · Jan 20, 2020 · adea447 · adea447
1 parent 48e6dce
commit adea447
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -73,6 +73,7 @@
 
 - #### 🛠 Fixes
 
+  - Fixed JS typo in RenderService. This was causing animation frames to not be dropped correctly. [[@jstarry], [#658](https://github.com/yewstack/yew/pull/658)]
   - Fixed `VNode` orphaning bug when destroying `VTag` elements. This caused some `Component`s to not be properly destroyed when they should have been. [[@hgzimmerman], [#651](https://github.com/yewstack/yew/pull/651)]
   - Fix mishandling of Properties `where` clause in derive_props macro [[@astraw], [#640](https://github.com/yewstack/yew/pull/640)]
 

diff --git a/src/services/render.rs b/src/services/render.rs
@@ -54,7 +54,7 @@ impl Task for RenderTask {
         let handle = self.0.take().expect("tried to cancel render twice");
         js! { @(no_return)
             var handle = @{handle};
-            cancelAnimationFrame(handle.timeout_id);
+            cancelAnimationFrame(handle.render_id);
             handle.callback.drop();
         }
     }