Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple topologies and operators #403

Closed
wants to merge 3 commits into from
Closed

Decouple topologies and operators #403

wants to merge 3 commits into from

Conversation

whzup
Copy link
Collaborator

@whzup whzup commented May 18, 2020

Description

Removed the compute_velocity and compute_position methods in the topologies to decouple them.

Related Issue

#259

Motivation and Context

There was no reason for the methods to be in the topologies. This change makes the backend more coherent.

How Has This Been Tested?

Tests run.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@whzup whzup added documentation Documentation improvements or fixes enhancement Feature requests refactor Better code quality, idiomatic Python labels May 18, 2020
@ljvmiranda921 ljvmiranda921 self-requested a review May 21, 2020 13:46
@ljvmiranda921
Copy link
Owner

Hey @whzup ! Thanks for this! Let me check this over the weekend :)

Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @whzup ! Just for formatting, can you run black on all affected files?

@ljvmiranda921
Copy link
Owner

I like this PR, we're removing more code (feels good!). Let's fix the conflicts first (mostly imports because of black) then this is good to merge!

Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix some conflicts first (some import formatting due to black), then we're good to merge!

@stale
Copy link

stale bot commented Jul 25, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Not much activity here label Jul 25, 2020
@stale stale bot closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements or fixes enhancement Feature requests refactor Better code quality, idiomatic Python stale Not much activity here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants