Create GeneralOptimizer class and fix index error in Pyramid class #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a GeneralOptimizer class with a topology parameter so one can choose which topology to use. Some special additions implemented: - Added an error message in case the topology attribute has the wrong type. - Added a special case for the ring topology so it's the same as local optimization. Also, created the corresponding test file and updated the documentation as well as the RST files for the GeneralOptimizer as well as the Pyramid topology. Resolves: #148
Fixed an index error in the Pyramid class that occured because the type of the idx array did not match 'int'
ljvmiranda921
added
enhancement
ljvmiranda921
approved these changes
Jul 4, 2018
There was a problem hiding this comment.
Looks good to me! Thanks for this @whzup ! Hopefully I can merge this next week Tuesday! Just need to try this implementation again.
|
Nice, no problem @ljvmiranda921! By the way, I already have a Random topology almost ready for a PR. It's built on the branch used for this PR so I'll wait until you merge this one before making the next. |
|
Should I include a citation to this paper in the |
|
Merged! Thanks for this @whzup ! You're awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a
GeneralOptimizerclass for the implementation of new topologies. Updated the documentation and created a new test file for the new class. With the new test file, it became possible to test thePyramidclass (topology) more easily.Fixed an index error that occurred in the
Pyramidtopology because of a type mismatch.Resolves: #148