-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plotting module #130
Labels
enhancement
Feature requests
Comments
Closed
ljvmiranda921
added
documentation
Documentation improvements or fixes
unit tests
Test-related changes
labels
Jun 12, 2018
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 13, 2018
Reference: #130 This commit adds a plotters.py module to replace the environments module. We hope that we can actually decouple the optimization and visualization part, without having the environment to do another rollout of your PSO. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 13, 2018
Reference: #130 The problem before is that we tend to have many parameters in our plotting functions. The formatters module changes that. We have three types of formatters: Designer, Animator, and Mesher. There are defaults present, but the user can change and pass them to the ploting functions whenever needed. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 13, 2018
Reference: #130 This commit adds a plotters.py module to replace the environments module. We hope that we can actually decouple the optimization and visualization part, without having the environment to do another rollout of your PSO. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 13, 2018
Reference: #130 The problem before is that we tend to have many parameters in our plotting functions. The formatters module changes that. We have three types of formatters: Designer, Animator, and Mesher. There are defaults present, but the user can change and pass them to the ploting functions whenever needed. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 13, 2018
Reference: #130 This commit adds a plotters.py module to replace the environments module. We hope that we can actually decouple the optimization and visualization part, without having the environment to do another rollout of your PSO. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 13, 2018
Reference: #130 The problem before is that we tend to have many parameters in our plotting functions. The formatters module changes that. We have three types of formatters: Designer, Animator, and Mesher. There are defaults present, but the user can change and pass them to the ploting functions whenever needed. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
Reference: #130 This commit adds a plotters.py module to replace the environments module. We hope that we can actually decouple the optimization and visualization part, without having the environment to do another rollout of your PSO. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
Reference: #130 The problem before is that we tend to have many parameters in our plotting functions. The formatters module changes that. We have three types of formatters: Designer, Animator, and Mesher. There are defaults present, but the user can change and pass them to the ploting functions whenever needed. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
This commit adds the plotters module into ReadTheDocs index and adds a deprecated information on plot_environment.py Signed-off-by: Lester James V. Miranda <[email protected]> [WIP-env] Add deprecated to env docs [WIP] Add plotters DOCS
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
This commit updates the docstrings in formatters.py and adds a legend attribute in plotters.py Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
Reference: #130 This commit adds a plotters.py module to replace the environments module. We hope that we can actually decouple the optimization and visualization part, without having the environment to do another rollout of your PSO. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
Reference: #130 The problem before is that we tend to have many parameters in our plotting functions. The formatters module changes that. We have three types of formatters: Designer, Animator, and Mesher. There are defaults present, but the user can change and pass them to the ploting functions whenever needed. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
This commit adds the plotters module into ReadTheDocs index and adds a deprecated information on plot_environment.py Signed-off-by: Lester James V. Miranda <[email protected]> [WIP-env] Add deprecated to env docs [WIP] Add plotters DOCS
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
This commit updates the docstrings in formatters.py and adds a legend attribute in plotters.py Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
Reference: #130 This commit adds a plotters.py module to replace the environments module. We hope that we can actually decouple the optimization and visualization part, without having the environment to do another rollout of your PSO. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
Reference: #130 The problem before is that we tend to have many parameters in our plotting functions. The formatters module changes that. We have three types of formatters: Designer, Animator, and Mesher. There are defaults present, but the user can change and pass them to the ploting functions whenever needed. Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
This commit adds the plotters module into ReadTheDocs index and adds a deprecated information on plot_environment.py Signed-off-by: Lester James V. Miranda <[email protected]>
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
This commit updates the docstrings in formatters.py and adds a legend attribute in plotters.py Signed-off-by: Lester James V. Miranda <[email protected]>
Merged
ljvmiranda921
pushed a commit
that referenced
this issue
Jun 14, 2018
ljvmiranda921
added
v0.3.0
and removed
documentation
Documentation improvements or fixes
unit tests
Test-related changes
labels
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it is better to decouple visualization from optimization.
Before, we have a
PlotEnviroment
class that takes an optimizer instance, runsthe optimization, and plots whatever the user requires (cost history, animations, etc.).
Some problems I see:
PlotEnvironment
classwill repeat this whole process again?
I found in this rollout?
PlotEnvironment
will just ignore that because it has its own rollout.It's better if we have the user do the optimization first, get the histories (via the properties
in the
SwarmOptimizer
class, e.g.my_optimizer.cost_history
) and pass that to the plottingfunction (doesn't need to be contained in a class)
Rough draft:
The text was updated successfully, but these errors were encountered: