Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dist folder missing when using bower #148

Closed
sankethkatta opened this issue Jan 26, 2016 · 7 comments
Closed

/dist folder missing when using bower #148

sankethkatta opened this issue Jan 26, 2016 · 7 comments

Comments

@sankethkatta
Copy link

In v6.0.0, there was a /dist checked into the repository which worked for both bower and npm installs.

However, now the /dist generation has been moved to prepublish in package.json, this only works for npm. Which breaks any workflows with bower that were depending on the built qs.js file being present.

One solution would be to generate /dist on one of the bower hooks.

@ljharb
Copy link
Owner

ljharb commented Jan 31, 2016

Per #129, this project will be removing bower support. v6.0 broke it anyways for non-ES6 browsers, and in 2016 it's long past time for folks to be using npm + browserify/webpack to consume JS assets.

I could certainly restore the dist directory briefly, prior to releasing v7.0 (no concrete date yet), but I'm not sure I see the benefit.

@sankethkatta
Copy link
Author

Fully understand that bower support will be removed and there are much better ways of consuming JS assets. I created this issue mainly because a minor version increase to v6.0.2 broke our builds, ^ and the stricter ~ fetch the latest minor version, but thats more a semver / versioning issue.

Maybe just a notice on the README that bower support has been / will be dropped would be nice.

@ljharb
Copy link
Owner

ljharb commented Jan 31, 2016

That's a really fair point, technically removing dist is a breaking change in a non-major version bump.

I'll revert it for now, and wait to remove dist until v7.

@ljharb ljharb closed this as completed in c8857a0 Jan 31, 2016
@ljharb ljharb added this to the 6.1.0 milestone Feb 4, 2016
@ljharb ljharb modified the milestones: 7.0.0, 6.1.0 Jul 20, 2016
@ljharb ljharb reopened this Jul 20, 2016
@ljharb ljharb self-assigned this Jul 21, 2016
@ljharb ljharb closed this as completed in 938f24e Feb 16, 2017
@chrisknoll
Copy link

chrisknoll commented Jan 14, 2021

It seems this folder is gone again in 6.9.5 (I think it was there in 6.5.2).

Edit: I just checked, and it was in 6.9.4, but not in 6.9.5. I would be very grateful if this folder could remain through the 6.x version of the library.

@ljharb
Copy link
Owner

ljharb commented Jan 14, 2021

This was an unintentional regression in d4f6c32; i'll publish a v6.9.6 shortly that restores it.

While I'm committed to maintaining bower compatibility until v7, I would also strongly encourage you to migrate away from a 3-5 years deprecated curl wrapper.

@ljharb
Copy link
Owner

ljharb commented Jan 14, 2021

v6.9.6 is published, sorry for the inconvenience.

@chrisknoll
Copy link

Thank you so much @ljharb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants