-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cloning typed arrays #3
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
437a656
to
b56e46a
Compare
b56e46a
to
aa6c277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased this, and pulled some of the smaller changes into main.
aa6c277
to
c662397
Compare
This seems good; I’ve got a bunch of TODOs to replace inline code with deps, so I’m thinking about the best release plan for that before merging this. |
2527b11
to
18c32c5
Compare
@scagood turns out Please fetch my latest changes and work off of those; I'll mark this PR as a draft until the tests are passing again. |
This fixes a crash in node 0.8 and 0.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This attempts to fix Typed Array cloning.
I had to add a node version check in the tests because:
TypedArray.from
was added in node 4Image of failed test runs in actions summary
I have pre-run all the tests already here: