Fix eslint7 ruletester improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshi-toma
commented
May 9, 2020
| code: [ | ||
| 'var First = createReactClass({', | ||
| ' propTypes: {', | ||
| ' s: PropTypes.shape({,', |
There was a problem hiding this comment.
This test code was throwing parse error :(
There was a problem hiding this comment.
Oops, That was my misunderstanding.
There was a problem hiding this comment.
Oops, Now, I checked with ESLint v7.
The test is throwing error...
1) forbid-prop-types
invalid
var First = createReactClass({
propTypes: {
s: PropTypes.shape({,
o: PropTypes.object
})
},
render: function() {
return <div />;
}
});:
AssertionError [ERR_ASSERTION]: A fatal parsing error occurred: Parsing error: Unexpected token ,
+ expected - actual
-false
+true
at runRuleForItem (node_modules/eslint/lib/rule-tester/rule-tester.js:559:13)
at testInvalidTemplate (node_modules/eslint/lib/rule-tester/rule-tester.js:650:28)
at Context.RuleTester.it (node_modules/eslint/lib/rule-tester/rule-tester.js:874:25)
There was a problem hiding this comment.
Comma may have been the cause ...??
{,
o: PropTypes.object
}
toshi-toma
commented
May 9, 2020
| options: [2], | ||
| errors: [{message: 'Expected indentation of 4 space characters but found 0.'}] | ||
| }, { |
There was a problem hiding this comment.
This test can't pass because jsx-indent is applying mistakenly indent.
I ignored the test. I could not understand How to fix it 😭
ljharb
force-pushed
the
fix-eslint7-ruletester-Improvements
branch
2 times, most recently
from
084ef41 to
72aeab3
Compare
ljharb
requested changes
May 9, 2020
| code: [ | ||
| 'var First = createReactClass({', | ||
| ' propTypes: {', | ||
| ' s: PropTypes.shape({,', |
ljharb
force-pushed
the
fix-eslint7-ruletester-Improvements
branch
from
72aeab3 to
b2f1f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/eslint/rfcs/blob/master/designs/2019-rule-tester-improvements/README.md