Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] add tests for evaluteCommitStatus #59

Merged
merged 1 commit into from
Feb 25, 2022
Merged

[Tests] add tests for evaluteCommitStatus #59

merged 1 commit into from
Feb 25, 2022

Conversation

dani8439
Copy link
Contributor

No description provided.

bin/can-merge Outdated Show resolved Hide resolved
test/mocks/evalCommit.js Outdated Show resolved Hide resolved
@dani8439
Copy link
Contributor Author

I've amended the data. Hopefully, it looks correct to you now that it's expanded. Automatic rebase failed.

Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! The only thing that seems to be missing is testing commitStatus.STATUS_NOT_FOUND.

@dani8439
Copy link
Contributor Author

It's there at the bottom of evalCommit.js : { "commitStatus": { "statusCheckRollup": null }, "expected": commitStatus.STATUS_NOT_FOUND, "description": "ℹ No commit checks were found" }

When using fs.writeFileSync to print it out to a new file, all I'm getting back when testing for a "No commit checks were found" is {"statusCheckRollup":null}. Unless I'm missing something and should be getting a bigger response?

@ljharb
Copy link
Owner

ljharb commented Feb 24, 2022

tbh i have no idea :-) if that's what the API is giving you then that's probably right

@ljharb ljharb changed the title Integrate evaluteCommitStatus into existing tests. [Tests] add tests for evaluteCommitStatus Feb 25, 2022
@ljharb ljharb merged commit a5e22a7 into main Feb 25, 2022
@ljharb ljharb deleted the testing branch February 25, 2022 05:52
@ljharb ljharb mentioned this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants