Fix flaky visualize lab mode tests (elastic#20165)

* Update saveSearch method in discover and add wait page loading for advance settings * Fix spaces
liza-mae · Jun 26, 2018 · a9c5a3d · a9c5a3d
1 parent d44abbb
commit a9c5a3d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 14 deletions.
diff --git a/test/functional/page_objects/discover_page.js b/test/functional/page_objects/discover_page.js
@@ -32,20 +32,12 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
         .getVisibleText();
     }
 
-    saveSearch(searchName) {
-      return this.clickSaveSearchButton()
-        .then(() => {
-          log.debug('--saveSearch button clicked');
-          return getRemote().findDisplayedById('SaveSearch')
-            .pressKeys(searchName);
-        })
-        .then(() => {
-          log.debug('--find save button');
-          return testSubjects.click('discoverSaveSearchButton');
-        })
-        .then(async () => {
-          return await testSubjects.exists('saveSearchSuccess', 2000);
-        });
+    async saveSearch(searchName) {
+      log.debug('saveSearch');
+      await this.clickSaveSearchButton();
+      await getRemote().findDisplayedById('SaveSearch').pressKeys(searchName);
+      await testSubjects.click('discoverSaveSearchButton');
+      await PageObjects.header.waitUntilLoadingHasFinished();
     }
 
     async getColumnHeaders() {
@@ -56,6 +48,7 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
     async openSavedSearch() {
       await this.clickLoadSavedSearchButton();
       await testSubjects.exists('loadSearchForm');
+      await PageObjects.header.waitUntilLoadingHasFinished();
     }
 
     async hasSavedSearch(searchName) {

diff --git a/test/functional/page_objects/settings_page.js b/test/functional/page_objects/settings_page.js
@@ -25,6 +25,7 @@ export function SettingsPageProvider({ getService, getPageObjects }) {
 
     async clickKibanaSettings() {
       await this.clickLinkText('Advanced Settings');
+      await PageObjects.header.waitUntilLoadingHasFinished();
     }
 
     async clickKibanaSavedObjects() {