Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dir relative to page and auto-generate thumbnails #41

Closed
wants to merge 1 commit into from

Conversation

awein
Copy link

@awein awein commented Jan 5, 2019

Thanks for this great project!

I would like to suggest the following changes:

  • Use page resources to organize is really nice and clean. That's why dir is relative to the page directory now.
  • Automatic creation of thumbnails makes this even more nice and easy thanks to the image processing
    feature
    .

@liwenyip
Copy link
Owner

Hi @awein

Thanks for your contribution.

I'm definitely keen to adopt page resources, as it simplifies a lot of things; but I want to have a transition where users can choose to create galleries the old way using images in static or the new way using page resources.

This a duplicate of #46 so I'm going to close this PR for now.

Thanks,
Li-Wen

@liwenyip liwenyip closed this Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants