Pragma2ifndef (vesoft-inc#3716)

* add cmake git hooks options

* githooks option

* include what you use

* make name follow convention

* linker support lld, which is the fastest linker. If ci
install lld when pull request , will set lld as default linker.

* log rotate

* delete werror

* pragma once => ifndef

* pragma once => ifndef

* Werror bison

* format code

* fix issue 3601 (vesoft-inc#3666)

* fix meta upgrade for multi instance (vesoft-inc#3734)

* drop host only when it registe heartbeat (vesoft-inc#3739)

* Fix race of create tag and edge (vesoft-inc#3735)

* fix rece

* polish

* fix review

* Add version for `show hosts` (vesoft-inc#3702)

* version

* tck

* pytest

* pytest

Co-authored-by: cpw <[email protected]>

* Enhancement/set expression depth by flag (vesoft-inc#3722)

* Set expression depth limit by flag.

* Format.

Co-authored-by: Yichen Wang <[email protected]>

* Update client version to v3.0.0 (vesoft-inc#3741)

* Update python package name to v3

* Update client version white list

* Update go mod to v3

* Change the python package name used in tests

* Update client version white list

* Fix create fulltext index failed (vesoft-inc#3747)

* fix bug: the same tagId/edgetype under different spaces, failed to create fulltext indexes

* fix bug: the same tagId/edgetype under different spaces, failed to create fulltext indexes

* add comments and adjust log level for meta/processors/admin (vesoft-inc#3662)

* add comments and adjust log level for meta admin processors

* change agent hb log level

Co-authored-by: Doodle <[email protected]>

* fix writternBy delete by optimizer (vesoft-inc#3746)

* fix bugs

* add tck features

* style

Co-authored-by: cpw <[email protected]>

* fix with & optimizer rule error (vesoft-inc#3736)

* fix error

* fix collapseProjectRule

Co-authored-by: cpw <[email protected]>

* fix upgrade bug (vesoft-inc#3772)

Co-authored-by: Sophie <[email protected]>

* fix 3727 (vesoft-inc#3737)

Co-authored-by: Doodle <[email protected]>

* Balance fix (vesoft-inc#3668)

* fix core balance in zone removing the only host in zone

* fix balance plan that make redundant part

* fix deadlock when runInternal and finish callback called in the same thread

* fix transleader return TERM_OUT_OF_DATE

* continue running balance task from last status

* fix deadlock when removing part

Co-authored-by: Sophie <[email protected]>

* Eliminte the useless row collect. (vesoft-inc#3363)

* Eliminte the useless row collect.

* Remove comment.

* Format.

* Rebase.

Co-authored-by: cpw <[email protected]>
Co-authored-by: Sophie <[email protected]>

* Add snapshot for prefix iterate. (vesoft-inc#3717)

* Add snapshot for prefix iterate.

* Add header comment

* Add happy test

* Fix lint

* Modify engine snap argument position

* Fix other subclass

* Fix code

Co-authored-by: yaphet <[email protected]>
Co-authored-by: Sophie <[email protected]>
Co-authored-by: Doodle <[email protected]>

* Read lock zone when create space. (vesoft-inc#3693)

Co-authored-by: yaphet <[email protected]>
Co-authored-by: Sophie <[email protected]>

* suppress undesired ASAN error (vesoft-inc#3705)

* suppress undesired error

* fix unstable test case

* 1. add comments and change log level for meta (vesoft-inc#3709)

2. remove some unused meta kv files
3. remove unused tests
4. remove unused kv relative tests in metaclient

Co-authored-by: Doodle <[email protected]>

* fix upgrade (vesoft-inc#3787)

Co-authored-by: Doodle <[email protected]>

* Create CODEOWNERS (vesoft-inc#3770)

Confirm with sophie.xie

* disable data balance (vesoft-inc#3756)

Co-authored-by: Sophie <[email protected]>

* Fix iterator with snapshot(parameter position) (vesoft-inc#3785)

Co-authored-by: Harris.Chu <[email protected]>
Co-authored-by: Sophie <[email protected]>

* disable meta upgrade from v1 (vesoft-inc#3798)

* Add gflag validator for client_idle_timeout_secs (vesoft-inc#3807)

Co-authored-by: Sophie <[email protected]>

* disable zone commands (vesoft-inc#3776)

Co-authored-by: cpw <[email protected]>

* Add ci for standalone compile and ut. (vesoft-inc#3637)

* Add standalone workflow

* remove tmp note

* Add meta v2 thrift obj for sa

* Add tck test

* Fix port and dist tck

* skip some test on sa

* Fix merge

* Fix add host

Co-authored-by: Sophie <[email protected]>

* Fix the promise/future. (vesoft-inc#3814)

Co-authored-by: jimingquan <[email protected]>

* add comments & accumulate bug fix for TOSS (vesoft-inc#3643)

* 1. add comments & adjust some log level
2. accumulate bug fix for TOSS
  2.1 one space may be affected by another space. when recover prime edges.
  2.2 when call kvstore->get(), if leaderLeaseInvalid, it will report leader_change, change it to
      leader_lease_failed.
  2.3 print all execution trace in ChainProcessor::finish(), make much more grep friendly.
  2.4 some function of memory lock is hard to understand (forceLock, forceUnlock) , change to
      "setAutoUnlock(bool)"

modify update

fix compile error

adjust finish()

adjust finish()

add rcPrepare_ = succeeded

adjust delete local processor

adjust log

use rcPrepare, rcRemote rcCommit

fix resume add edges

adjust UT

disable ioThreadPoolForMeta_

make int64 vid printable

adjust some log to vlog 2

only print prepare succeeded result

only print readable in finish() of resume processor

adjust some log

some log not print term

desc class name in uuid

debug

add some more log

looks like factory may fail?

add leader lease error code

add check when get lock

report leader lease

do some clean

change table prefix to NebulaKeyUtil Style

change some print

disable UT for short

clean

compile error

disable pool monitor

* unify add/delete finish() as update

* not stable will add it back later

* fix a clang warning

* fix a clang10 warning 2

Co-authored-by: Sophie <[email protected]>

* disable add hosts into zone (vesoft-inc#3825)

Co-authored-by: Sophie <[email protected]>

* Check active zone before create space (vesoft-inc#3822)

Co-authored-by: Sophie <[email protected]>

* abandon upgrader for old version (vesoft-inc#3818)

Co-authored-by: Sophie <[email protected]>

* put dataVersionKey on create space for storage (vesoft-inc#3817)

* put dataVersionKey on create space for storage

* address some comments

Co-authored-by: Doodle <[email protected]>
Co-authored-by: Sophie <[email protected]>

* Update PR template (vesoft-inc#3809)

Co-authored-by: Sophie <[email protected]>

* fix meta http replace host handler (vesoft-inc#3794)

* fix meta http replace host handler

* fix http replace test and add zone test

Co-authored-by: Sophie <[email protected]>

* Fix `Match cannot be followed by use space` (vesoft-inc#3748)

* fix bug

* add tck

* remove set

* fix

* rm header

* fix

* remove changes in match

* fix

* enhance annotation

* fix review

* fix

* fix review

* remove redundant

Co-authored-by: Sophie <[email protected]>
Co-authored-by: cpw <[email protected]>

* support toSet function (vesoft-inc#3594)

add test

Co-authored-by: Sophie <[email protected]>

* Enhance date parser (vesoft-inc#3797)

* parse date

* enhance datetime

* add test

* fix review

* rename

Co-authored-by: Sophie <[email protected]>

* raft: fix always loop when no log need to send (vesoft-inc#3819)

Co-authored-by: Sophie <[email protected]>
Co-authored-by: Doodle <[email protected]>

* Update CODEOWNERS (vesoft-inc#3835)

* Update CODEOWNERS

* Update CODEOWNERS

Confirm with sophie.xie

* refactor AdminClient (vesoft-inc#3781)

* refactor AdminClient

* fix test case, unify all getAdminAddrFromStoreAddr into AdminClient

* add more test cases

* address @panda-sheep's comment

* Feature/optimizer trait match (vesoft-inc#3769)

* Add trait for pattern match.

* Implement match plan by trait and reduce some reduncant rules.

* Remove unused header.

* Fix warning.

* Let optimize rule decide collection of matched nodes.

Co-authored-by: kyle.cao <[email protected]>
Co-authored-by: Sophie <[email protected]>

* Simplify datetime tostring. (vesoft-inc#3712)

* Simplify datetime tostring.

* Remove unused code.

* Fix error.

Co-authored-by: Sophie <[email protected]>

* pragma once not allowd (vesoft-inc#3842)

Co-authored-by: Sophie <[email protected]>

* refactor LOG and add comment for meta, meta/processors/job (vesoft-inc#3686)

* refactor LOG and add comment for meta, meta/processors/job

* refactor LOG and add comment for meta/processors/zone

Co-authored-by: Doodle <[email protected]>

* replace STRING to name_label for zone's name (vesoft-inc#3780)

Co-authored-by: Doodle <[email protected]>

* Add test for rc. (vesoft-inc#3847)

* Add test for rc.

* Fix cxx.

Confirm with sophie.xie

* cpp lint

Co-authored-by: Yee <[email protected]>
Co-authored-by: Sophie <[email protected]>
Co-authored-by: cpw <[email protected]>
Co-authored-by: hs.zhang <[email protected]>
Co-authored-by: yaphet <[email protected]>
Co-authored-by: jakevin <[email protected]>
Co-authored-by: shylock <[email protected]>
Co-authored-by: Yichen Wang <[email protected]>
Co-authored-by: panda-sheep <[email protected]>
Co-authored-by: pengwei.song <[email protected]>
Co-authored-by: Doodle <[email protected]>
Co-authored-by: endy.li <[email protected]>
Co-authored-by: jimingquan <[email protected]>
Co-authored-by: liwenhui-soul <[email protected]>
Co-authored-by: Alex Xing <[email protected]>
Co-authored-by: Harris.Chu <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: kyle.cao <[email protected]>

src/clients/meta/stats/MetaClientStats.h

@@ -3,8 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
-
+#ifndef CLIENTIS_META_STATS_METACLIENTSTATS_H
+#define CLIENTIS_META_STATS_METACLIENTSTATS_H
 #include "common/stats/StatsManager.h"
 
 namespace nebula {
@@ -15,3 +15,4 @@ extern stats::CounterId kNumRpcSentToMetadFailed;
 void initMetaClientStats();
 
 }  // namespace nebula
+#endif

src/clients/storage/StorageClient.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef CLIENTS_STORAGE_STORAGECLIENT_H
+#define CLIENTS_STORAGE_STORAGECLIENT_H
 
 #include <gtest/gtest_prod.h>
 
@@ -192,3 +193,4 @@ class StorageClient
 
 }  // namespace storage
 }  // namespace nebula
+#endif

src/clients/storage/StorageClientBase-inl.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef CLIENTS_STORAGE_STORAGECLIENTBASE_INL_H
+#define CLIENTS_STORAGE_STORAGECLIENTBASE_INL_H
 
 #include <folly/Try.h>
 
@@ -379,3 +380,4 @@ StorageClientBase<ClientType, ClientManagerType>::getHostPartsWithCursor(
 
 }  // namespace storage
 }  // namespace nebula
+#endif

src/clients/storage/stats/StorageClientStats.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef CLIENTS_STORAGE_STATS_STORAGECLIENTSTATS_H
+#define CLIENTS_STORAGE_STATS_STORAGECLIENTSTATS_H
 
 #include "common/stats/StatsManager.h"
 
@@ -15,3 +16,4 @@ extern stats::CounterId kNumRpcSentToStoragedFailed;
 void initStorageClientStats();
 
 }  // namespace nebula
+#endif

src/codec/include/NebulaCodec.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef CODEC_INCLUDE_NEBULACODEC_H
+#define CODEC_INCLUDE_NEBULACODEC_H
 
 #include "common/base/StatusOr.h"
 #include "common/meta/SchemaProviderIf.h"
@@ -24,3 +25,4 @@ class NebulaCodec {
 };
 
 }  // namespace nebula
+#endif

src/codec/test/RowWriterV1-inl.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef CODEC_TEST_ROWWRITERV1_INL_H
+#define CODEC_TEST_ROWWRITERV1_INL_H
 
 namespace nebula {
 
@@ -45,3 +46,4 @@ typename std::enable_if<std::is_integral<T>::value>::type RowWriterV1::writeInt(
 }
 
 }  // namespace nebula
+#endif

src/common/base/CollectNSucceeded-inl.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_BASE_COLLECTNSUCCEEDED_INL_H
+#define COMMON_BASE_COLLECTNSUCCEEDED_INL_H
 
 #include <folly/ExceptionWrapper.h>
 
@@ -67,3 +68,4 @@ folly::Future<SucceededResultList<FutureIter>> collectNSucceeded(FutureIter firs
 }
 
 }  // namespace nebula
+#endif

src/common/base/ICord.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_BASE_ICORD_H
+#define COMMON_BASE_ICORD_H
 
 #include "common/base/Base.h"
 
@@ -244,3 +245,4 @@ class ICord {
 };
 
 }  // namespace nebula
+#endif

src/common/datatypes/Duration.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_DATATYPES_DURATION_H
+#define COMMON_DATATYPES_DURATION_H
 
 #include <folly/dynamic.h>
 
@@ -150,3 +151,4 @@ struct hash<nebula::Duration> {
 };
 
 }  // namespace std
+#endif

src/common/datatypes/DurationOps-inl.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_DATATYPES_DURATIONOPS_INL_H
+#define COMMON_DATATYPES_DURATIONOPS_INL_H
 
 #include <thrift/lib/cpp2/GeneratedCodeHelper.h>
 #include <thrift/lib/cpp2/gen/module_types_tcc.h>
@@ -199,3 +200,4 @@ uint32_t Cpp2Ops<nebula::Duration>::serializedSizeZC(Protocol const* proto,
 
 }  // namespace thrift
 }  // namespace apache
+#endif

src/common/datatypes/Geography.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_DATATYPES_GEOGRAPHY_H
+#define COMMON_DATATYPES_GEOGRAPHY_H
 
 #include <s2/s2point.h>
 #include <s2/s2point_region.h>
@@ -239,3 +240,4 @@ struct hash<nebula::Geography> {
 };
 
 }  // namespace std
+#endif

src/common/geo/GeoFunction.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_GEOFUNCTION_H
+#define COMMON_GEO_GEOFUNCTION_H
 
 #include <s2/s2region_coverer.h>
 
@@ -73,3 +74,4 @@ class GeoFunction {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/GeoIndex.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_GEOINDEX_H
+#define COMMON_GEO_GEOINDEX_H
 
 #include <s2/s2region_coverer.h>
 
@@ -101,3 +102,4 @@ struct hash<S2CellId> {
 };
 
 }  // namespace std
+#endif

src/common/geo/GeoUtils.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_GEOUTILS_H
+#define COMMON_GEO_GEOUTILS_H
 
 #include <s2/s2latlng.h>
 #include <s2/s2loop.h>
@@ -96,3 +97,4 @@ class GeoUtils final {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/io/CMakeLists.txt

@@ -2,10 +2,18 @@
 #
 # This source code is licensed under Apache 2.0 License.
 
-if(ENABLE_VERBOSE_BISON)
-    set(bison_flags "-Werror -v")
+if(ENABLE_ERROR)
+  if(ENABLE_VERBOSE_BISON)
+      set(bison_flags "-Werror -v")
+  else()
+      set(bison_flags "-Werror")
+  endif()
 else()
-    set(bison_flags "-Werror")
+  if(ENABLE_VERBOSE_BISON)
+      set(bison_flags "-v")
+  else()
+      set(bison_flags "")
+  endif()
 endif()
 bison_target(Parser wkt/wkt_parser.yy ${CMAKE_CURRENT_BINARY_DIR}/wkt/WKTParser.cpp COMPILE_FLAGS ${bison_flags})
 flex_target(Scanner wkt/wkt_scanner.lex ${CMAKE_CURRENT_BINARY_DIR}/wkt/WKTScanner.cpp)

src/common/geo/io/wkb/ByteOrder.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_IO_WKB_BYTEORDER_H
+#define COMMON_GEO_IO_WKB_BYTEORDER_H
 
 #include <boost/endian/conversion.hpp>
 
@@ -76,3 +77,4 @@ struct ByteOrderData {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/io/wkb/ByteOrderDataIOStream.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_IO_WKB_BYTEORDERDATAIOSTREAM_H
+#define COMMON_GEO_IO_WKB_BYTEORDERDATAIOSTREAM_H
 
 #include <sstream>
 
@@ -73,3 +74,4 @@ class ByteOrderDataOutStream {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/io/wkb/WKBReader.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_IO_WKB_WKBREADER_H
+#define COMMON_GEO_IO_WKB_WKBREADER_H
 
 #include "common/base/Base.h"
 #include "common/base/StatusOr.h"
@@ -45,3 +46,4 @@ class WKBReader {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/io/wkb/WKBWriter.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_IO_WKB_WKBWRITER_H
+#define COMMON_GEO_IO_WKB_WKBWRITER_H
 
 #include "common/base/Base.h"
 #include "common/datatypes/Geography.h"
@@ -43,3 +44,4 @@ class WKBWriter {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/io/wkt/WKTReader.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_IO_WKT_WKTREADER_H
+#define COMMON_GEO_IO_WKT_WKTREADER_H
 
 #include "common/base/Base.h"
 #include "common/base/StatusOr.h"
@@ -81,3 +82,4 @@ class WKTReader {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/io/wkt/WKTScanner.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_IO_WKT_WKTSCANNER_H
+#define COMMON_GEO_IO_WKT_WKTSCANNER_H
 
 #include "common/base/Base.h"
 
@@ -75,3 +76,4 @@ class WKTScanner : public yyFlexLexer {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/geo/io/wkt/WKTWriter.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_GEO_IO_WKT_WKTWRITER_H
+#define COMMON_GEO_IO_WKT_WKTWRITER_H
 
 #include "common/base/Base.h"
 #include "common/datatypes/Geography.h"
@@ -31,3 +32,4 @@ class WKTWriter {
 
 }  // namespace geo
 }  // namespace nebula
+#endif

src/common/log/LogMonitor.h

@@ -2,7 +2,8 @@
  *
  * This source code is licensed under Apache 2.0 License.
  */
-#pragma once
+#ifndef COMMON_LOG_LOGMONITOR_H
+#define COMMON_LOG_LOGMONITOR_H
 
 #include <boost/filesystem.hpp>
 #include <boost/system/error_code.hpp>
@@ -41,3 +42,4 @@ class LogMonitor {
 };
 
 }  // namespace nebula
+#endif

src/common/memory/MemoryUtils.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_MEMORY_MEMORYUTILS_H
+#define COMMON_MEMORY_MEMORYUTILS_H
 
 #include <atomic>
 #include <cstdint>
@@ -33,3 +34,4 @@ class MemoryUtils final {
 };
 
 }  // namespace nebula
+#endif

src/common/ssl/SSLConfig.h

@@ -4,7 +4,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_SSL_SSLCONFIG_H
+#define COMMON_SSL_SSLCONFIG_H
 
 #include <folly/io/async/SSLContext.h>
 #include <gflags/gflags.h>
@@ -23,3 +24,4 @@ extern std::shared_ptr<wangle::SSLContextConfig> sslContextConfig();
 extern std::shared_ptr<folly::SSLContext> createSSLContext();
 
 }  // namespace nebula
+#endif

src/common/stats/StatsManager-inl.h

@@ -3,7 +3,8 @@
  * This source code is licensed under Apache 2.0 License.
  */
 
-#pragma once
+#ifndef COMMON_STATS_STATSMANAGER_INL_H
+#define COMMON_STATS_STATSMANAGER_INL_H
 
 namespace nebula {
 namespace stats {
@@ -30,3 +31,4 @@ StatsManager::VT StatsManager::readValue(StatsHolder& stats,
 
 }  // namespace stats
 }  // namespace nebula
+#endif