-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to Laravel 9 #129
base: master
Are you sure you want to change the base?
Conversation
Sorry, I missed this completely! Will verify soon ™️ 🙃 |
closes #131 |
@felixkiss I would really like this to be merged due to reasons explained in this PR for a different package where I had the same problem: laravelista/comments#183 (comment) I have looked through the codebase vs the upgrade guide vs this PR I am being held up by the reasons mentioned previously - but in short, If you merge this to master or another branch then that branch can be used without having to add a custom repo fork (laravel shift fork, etc) to each of my apps (just because they use a package which in turn uses this package). Looking at your branch structure - there's only a single master branch - I would say your branching strategy appears different to that used in laravelista/comments (you probably don't use master as an experimental or unstable branch) - therefore I would suggest you simply change the base of the This is the last remaining dependency for all of my laravel apps to be upgraded - I would appreciate it if you could consider my requests. Any help is appreciated and I thank you for your contribution to this package which in turn helps packages that my package uses. ❤️ edit: my mistake; the laravelista PR was a shift PR, thanks @gallib for this PR |
Any update? |
@felixkiss any chance of getting this in? |
Any update on this PR? |
Hi, |
Hi,
this PR just add support to upcoming Laravel 9.0