This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
Add page for account activation #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcauberer
added
enhancement
Splines
approved these changes
Apr 28, 2021
| @@ -0,0 +1,17 @@ | |||
| /* | |||
There was a problem hiding this comment.
Like you said: try to figure out a way so that you don't have to use inidvidual dummy ng routing modules for every single page. Of course, you can still merge this as this can still be implemented in the future.
| display: flex | ||
| height: 100vh | ||
| align-items: center | ||
| justify-content: center |
|
|
||
| ngOnInit(): void { | ||
| this.route.params.subscribe(params => { | ||
| this.accountService.confirm(params.token).subscribe((_) => { |
There was a problem hiding this comment.
(_) kind of bugs me 😅 Maybe find a way to tell our code inspector to ignore this one. I see no benefit in wrapping an underscore in parantheses, it just adds another step for my brain to ignore these parentheses when reading the code and thus makes it harder to understand (although only slightly).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<frontend-url>/activate/<token>