Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordtester: Fix session checks for catalyst recording tests #293

Merged
merged 7 commits into from
May 19, 2023

Conversation

victorges
Copy link
Member

@victorges victorges commented May 16, 2023

Review with "ignore whitespace changes" so the diff is cleaner.

This fixes the record-tester behavior for catalyst recording tests:

  • It expects 2 session objects instead of only 1 as before
  • It allows configuring for how long it should wait for the recording to be available
    • (might wanna add some polling if we need a too high limit here)
  • Default to not using forceUrl which is not supported anymore
  • Tests all 2 sessions streamed instead of only the last one

@victorges victorges requested a review from a team as a code owner May 16, 2023 18:51
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change is ok, though I didn't manage to run it successfully locally. Let's discuss more in Discord.

internal/app/recordtester/recordtester_app.go Outdated Show resolved Hide resolved
internal/app/recordtester/recordtester_app.go Outdated Show resolved Hide resolved
internal/app/recordtester/recordtester_app.go Outdated Show resolved Hide resolved
@victorges victorges merged commit 20a2379 into master May 19, 2023
@victorges victorges deleted the vg/fix/catalyst-recordings-test branch May 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants