mapic: Fix stats collection deadlock #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realized that we can't really use SetLimit with recursive Go calls, as we might get to a state where all routines are blocked waiting for another routine to finish. Fixed it by removing that recursion and parallelizing only the SetActive+Publish calls.
I hate that go bug
victorges
force-pushed
the
vg/fix/metrics-collection-deadlock
branch
from
0ac9aeb to
e4fd237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that we can't really use SetLimit with
recursive Go calls, as we might get to a state
where all routines are blocked waiting for another
routine to finish.
Fixed it by removing that recursion and parallelizing
only the SetActive+Publish calls.