feat: Make mapic stateless #221
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victorges
force-pushed
the
vg/fix/statefulness
branch
from
8b5b8c3 to
dfeb437
Compare
| info.mu.Unlock() | ||
| return | ||
| } | ||
| glog.Infof("Started multistream to target. targetId=%s stream=%s url=%s", wildcardPlaybackID, targetRef.ID, selectorURL) | ||
| info.mu.Unlock() | ||
| glog.Infof("Started multistream to target. targetId=%s stream=%s url=%s", wildcardPlaybackID, targetRef.ID, pushURL) |
Check failure
Code scanning / CodeQL
Log entries created from user input
victorges
force-pushed
the
vg/fix/statefulness
branch
from
729de88 to
a8726e5
Compare
victorges
changed the title
victorges
changed the title
| var videoSelector string | ||
| // Not actually the source. But the highest quality. | ||
| if targetRef.Profile == "source" { | ||
| videoSelector = "maxbps" |
There was a problem hiding this comment.
We just hit a bug with this in MistProcLivepeer where sometimes a transcoded rendition can be higher bitrate. @Thulinma is there a correct way for us to select just the source hre?
There was a problem hiding this comment.
FTR as we chatted about this, this is not a behavior change in this PR, it was only copied from the previous code. We can merge this as is and follow up with a fix for this later.
There was a problem hiding this comment.
MistProcLivepeer, since an update we rolled out during the holidays, can no longer select its own renditions as source for itself. That should handle this situation without any changes needed.
To answer the actual question: yes, sort-of. You can simply not specify any specific track selector (leave it default value), and set the default track selector to id_lth to prioritize the lowest-ID track of the type, which for live streams is guaranteed to be the source (or one of the source tracks, at least, if there is more than one video track in the source already).
There was a problem hiding this comment.
After looking at the context, I see this is actually about pushes rather than MistProcLivepeer itself. The same solution applies there, though: use no track selector and make sure the default selector sorting is set to id_lth to make this work as intended.
(We could introduce a specific "non-modified tracks only" selector to make this easier to do ad-hoc, too! Would be a small change, only a couple lines of code.)
victorges
force-pushed
the
vg/fix/statefulness
branch
from
227d229 to
9d9b7fd
Compare
just in case we ever change the push url logic
This reverts commit 3006d46.
victorges
force-pushed
the
vg/fix/statefulness
branch
from
4f89955 to
699ed54
Compare
| defer wg.Done() | ||
| updated, err := mc.lapi.DeactivateMany(ids) | ||
|
|
||
| glog.Infof("getStreamInfo: Fetching stream not found in memory. playbackID=%s", playbackID) |
Check failure
Code scanning / CodeQL
Log entries created from user input
| // Assume setup was all successful | ||
| multistreamStarted: true, | ||
| } | ||
| glog.Infof("getStreamInfo: Created info lazily for stream. playbackID=%s id=%s numPushes=%d", playbackID, stream.ID, len(pushes)) |
Check failure
Code scanning / CodeQL
Log entries created from user input
This is to remove the assumption on mapic code that it runs forever alongside mist and
allow for it to be restarted.
For this, removed 2 main aspects of the code where mapic behaved in a stateful way: