mapic: Invert flag to skip mist stats #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mist cant handle a boolean flag set to false, its default value must be false instead and it can only be set to true lol
iameli
reviewed
Oct 21, 2022
| @@ -41,7 +41,7 @@ func main() { | |||
| mistConnectTimeout := fs.Duration("mist-connect-timeout", 5*time.Minute, "Max time to wait attempting to connect to Mist server") | |||
| mistStreamSource := fs.String("mist-stream-source", "push://", "Stream source we should use for created Mist stream") | |||
| mistHardcodedBroadcasters := fs.String("mist-hardcoded-broadcasters", "", "Hardcoded broadcasters for use by MistProcLivepeer") | |||
| mistScrapeMetrics := fs.Bool("mist-scrape-metrics", true, "Scrape statistics from MistServer and publish to RabbitMQ") | |||
| noMistScrapeMetrics := fs.Bool("no-mist-scrape-metrics", true, "Scrape statistics from MistServer and publish to RabbitMQ") | |||
There was a problem hiding this comment.
Suggested change
| noMistScrapeMetrics := fs.Bool("no-mist-scrape-metrics", true, "Scrape statistics from MistServer and publish to RabbitMQ") | |
| noMistScrapeMetrics := fs.Bool("no-mist-scrape-metrics", false, "Scrape statistics from MistServer and publish to RabbitMQ") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mist cant handle a boolean flag set to false,
its default value must be false instead and
it can only be set to true lol