Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Build images for ghcr.io registry. #188

Merged
merged 3 commits into from
Aug 25, 2022
Merged

docker: Build images for ghcr.io registry. #188

merged 3 commits into from
Aug 25, 2022

Conversation

hjpotter92
Copy link
Member

@hjpotter92 hjpotter92 commented Aug 23, 2022 •
edited
Loading

  • Run dockfmt for all dockerfiles
  • Move built binaries to /usr/local/bin and leave a symlink in
    /root/ after builds
  • cleanups in readme; added docker image status badge to readme
  • add coverage reporting in (currently non-existent) tests

@hjpotter92
docker: Build images for ghcr.io registry.
467dd53 
 - Run `dockfmt` for all dockerfiles
 - Move built binaries to `/usr/local/bin` and leave a symlink in
  `/root/` after builds
@hjpotter92 hjpotter92 requested a review from a team as a code owner August 23, 2022 13:03
@hjpotter92 hjpotter92 self-assigned this Aug 23, 2022
@hjpotter92 hjpotter92 force-pushed the hjp/docker branch 2 times, most recently from 97ee917 to 76c224c Compare August 24, 2022 11:32
victorges
victorges approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/docker.yaml
strategy:
fail-fast: true
fail-fast: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 😀

@hjpotter92 hjpotter92 merged commit cd8f077 into master Aug 25, 2022
@hjpotter92 hjpotter92 deleted the hjp/docker branch August 25, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

Assignees

@hjpotter92 hjpotter92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjpotter92 @victorges