record-tester: Isolate stream health alerts from all others #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60320af.
iameli
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the most verbose of the tests and it is not 100% critical, so we shouldn't be paging
the on-call engineer with high urgency when they fire.
By keeping them together with all the other alerts, it also makes the other alerts less trusted
due to alert fatigue, and we end up ignoring real incidents.
On a higher level, we have moved away from the idea of the current Stream Health architecture
being the one and only source of truth for the Livepeer universe. So it is OK to start moving this
more to the background for now.