Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log to fatal if broadcaster is not ready and ignore comma in env var for flags #165

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Change log to fatal if broadcaster is not ready and ignore comma in env var for flags #165

merged 2 commits into from
Jun 14, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jun 13, 2022

No description provided.

@leszko leszko requested a review from victorges June 13, 2022 09:16
@leszko leszko requested a review from a team as a code owner June 13, 2022 09:16
@leszko leszko removed the request for review from a team June 13, 2022 09:16
@leszko leszko changed the title Ignore comma in env var for flags Change log to fatal if broadcaster is not ready and ignore comma in env var for flags Jun 13, 2022
victorges
victorges approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leszko leszko merged commit f4e2ef6 into master Jun 14, 2022
@leszko leszko deleted the 159-deploy-without-deps branch June 14, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leszko @victorges