Skip to content

Commit

Permalink
Reduce strictness of session count check (#281)
Browse files Browse the repository at this point in the history
* Reduce strictness of session count check

This is to help us reduce the noisiness of our record tester alerting

* review comments
  • Loading branch information
mjh1 authored Mar 29, 2023
1 parent 0b17fe1 commit f592c3a
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions internal/app/recordtester/recordtester_app.go
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,13 @@ func (rt *recordTester) Start(fileName string, testDuration, pauseDuration time.
return 252, err
}
glog.Infof("Sessions: %+v", sessions)
if len(sessions) != 1 {
err := fmt.Errorf("should have one session, got %d", len(sessions))
sessionsLength := len(sessions)
if sessionsLength == 2 {
// We often see failures for 2 sessions, this should be fixed once we move to catalyst recording but for now
// we want to ignore these to reduce the alert noise
return 0, nil
} else if sessionsLength != 1 {
err := fmt.Errorf("invalid session count, got %d", sessionsLength)
glog.Error(err)
// exit(251, fileName, *fileArg, err)
return 251, err
Expand Down

0 comments on commit f592c3a

Please sign in to comment.