-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add procps, vnstat, linux-tools #738
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but you can't rely on it being there any time soon, we don't roll pods much. What would you think of using this in catalyst-api instead? We're going to need something like it for the load balancing work. https://github.com/cloudfoundry/gosigar
4e8eac9
to
1485ebb
Compare
1485ebb
to
f41ee2c
Compare
@emranemran Do we still need this with all the system monitoring stuff landing in catabalancer? |
yes! this helps with per-process cpu/mem usage during specific operations in catalyst-api and the inter-parsing of these logs with catalyst-api helps narrow down issues quicker. |
f41ee2c
to
3995922
Compare
hmm do we think we don't need to reference it by kernel version?
|
Dockerfile
Outdated
@@ -80,6 +80,9 @@ RUN apt update && apt install -yqq \ | |||
ffmpeg \ | |||
nodejs \ | |||
gstreamer1.0-tools gstreamer1.0-plugins-good gstreamer1.0-plugins-base gstreamer1.0-plugins-bad \ | |||
procps \ | |||
vnstat \ | |||
linux-tools-common linux-tools-generic linux-tools-5.4.0-148-generic \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linux-tools-generic
alone should be enough. it should pick up correct linux-tools-<version>-generic
based on installed kernel version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, updating.
3995922
to
e53e270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Tests failing though, you. should rebase |
e53e270
to
2beaf4e
Compare
top
running on our pods and get access to better info.