Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rust::String::lossy for stringification to avoid crashing due to non-utf8 content #485

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Use rust::String::lossy for stringification to avoid crashing due to non-utf8 content #485

merged 1 commit into from
Nov 13, 2024

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Nov 13, 2024

This was causing crashes here in Zed's live kit test app when run on Linux.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@theomonnom theomonnom merged commit ee5076b into livekit:main Nov 13, 2024
4 of 5 checks passed
@theomonnom
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgsloan @CLAassistant @theomonnom