Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tasks being stuck while closing the PC #203

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: tasks being stuck while closing the PC #203

merged 1 commit into from
Sep 26, 2023

Conversation

theomonnom
Copy link
Member

  • It seems that SetRemoteDescription gets into a stuck state if we try to close the peer connections at the same time?

cc @cloudwebrtc

cloudwebrtc
cloudwebrtc approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theomonnom theomonnom merged commit 0627da4 into main Sep 26, 2023
14 checks passed
@theomonnom theomonnom deleted the theo/fix-stuck-signal-task branch September 26, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theomonnom @davidzhao @cloudwebrtc