Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed agent_dispatch.py typos #319

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

s-hamdananwar
Copy link
Contributor

No description provided.

@s-hamdananwar s-hamdananwar requested a review from kath0la December 6, 2024 06:37
Copy link

@kath0la kath0la left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@s-hamdananwar s-hamdananwar merged commit b84ba4c into main Dec 6, 2024
4 checks passed
@s-hamdananwar s-hamdananwar deleted the hamdan/fix-agent-dispatch-example-typo branch December 6, 2024 17:46
async def create_explicit_disptach(http_session: aiohttp.ClientSession):
agent_disptach_service = AgentDispatchService(
async def create_explicit_dispatch(http_session: aiohttp.ClientSession):
agent_dispatch_service = AgentDispatchService(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-hamdananwar, could you update this example to use api.LiveKitAPI() as seen on our docs (also fixing the imports to import protobuf types from livekit.api instead of livekit.protocol.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidzhao I have added it in this PR #322

@s-hamdananwar s-hamdananwar restored the hamdan/fix-agent-dispatch-example-typo branch December 10, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants