feat: new video buffer api #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
commented
Jan 30, 2024
theomonnom
commented
Jan 30, 2024
| @@ -31,16 +39,20 @@ def __init__( | |||
| track: Track, | |||
| loop: Optional[asyncio.AbstractEventLoop] = None, | |||
| capacity: int = 0, | |||
| format: Optional[proto_video_frame.VideoBufferType.ValueType] = None, | |||
There was a problem hiding this comment.
Can directly request a format from the VideoStream now
There was a problem hiding this comment.
great! let's explain these concepts in the docstring please. that the native format will be returned.
theomonnom
commented
Jan 30, 2024
| def capture_frame( | ||
| self, | ||
| frame: VideoFrame, | ||
| timestamp_us: int = 0, |
There was a problem hiding this comment.
how is timestamp used when the user sets it?
davidzhao
reviewed
Jan 31, 2024
| @@ -31,16 +39,20 @@ def __init__( | |||
| track: Track, | |||
| loop: Optional[asyncio.AbstractEventLoop] = None, | |||
| capacity: int = 0, | |||
| format: Optional[proto_video_frame.VideoBufferType.ValueType] = None, | |||
There was a problem hiding this comment.
great! let's explain these concepts in the docstring please. that the native format will be returned.
keepingitneil
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.