Add DataStream support #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f38498a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
…lukas/data-stream
…lukas/data-stream
…lukas/data-stream
…lukas/data-stream
…lukas/data-stream
boks1971
approved these changes
Nov 25, 2024
protobufs/livekit_models.proto
Outdated
| string messageId = 1; // unique identifier for this data stream to map it to the correct header | ||
| uint64 chunkIndex = 2; // chunkId as an unsigned 32-bit integer | ||
| bytes content = 3; // content as binary (bytes) | ||
| uint32 contentLength = 4; // content length in bytes |
There was a problem hiding this comment.
what is the purpose of this? can this not be derived from content as length of it? Are there cases where content is padded? (maybe for the encryption case?)
There was a problem hiding this comment.
yeah, although I'm not sure anymore what we'd need it for, even in the encryption case. Will remove and we can re-add if it turns out we need it
paulwe
approved these changes
Nov 25, 2024
paulwe
reviewed
Nov 25, 2024
cnderrauber
approved these changes
Nov 26, 2024
theomonnom
approved these changes
Nov 26, 2024
nbsp
approved these changes
Nov 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.