Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc): expose DisconnectReason #372

Merged
merged 7 commits into from
Jan 4, 2025
Merged

feat(rtc): expose DisconnectReason #372

merged 7 commits into from
Jan 4, 2025

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Jan 3, 2025

No description provided.

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 0bfd36d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/rtc-node Minor
@livekit/rtc-node-darwin-arm64 Minor
@livekit/rtc-node-darwin-x64 Minor
@livekit/rtc-node-linux-arm64-gnu Minor
@livekit/rtc-node-linux-x64-gnu Minor
@livekit/rtc-node-win32-x64-msvc Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nbsp nbsp requested review from lukasIO and davidzhao January 3, 2025 09:03
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice if this was part of the ParticipantDisconnected event payload as a second argument

@nbsp
Copy link
Member Author

nbsp commented Jan 3, 2025

I think it would be nice if this was part of the ParticipantDisconnected event payload as a second argument

it's already sent as part of the participant, so wouldn't it be redundant? i can see how it might be nice though

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nbsp nbsp merged commit 5b0a247 into main Jan 4, 2025
14 checks passed
@nbsp nbsp deleted the nbsp/bump/ffi-0.12.4 branch January 4, 2025 15:01
@github-actions github-actions bot mentioned this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants