Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add close method to AudioSource and VideoSource #365

Merged
merged 6 commits into from
Dec 29, 2024
Merged

Conversation

davidzhao
Copy link
Member

ensures we can clean up allocated resources correctly

ensures we can clean up allocated resources correctly
Copy link

changeset-bot bot commented Dec 27, 2024

🦋 Changeset detected

Latest commit: 7661abd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/rtc-node Patch
@livekit/rtc-node-darwin-arm64 Patch
@livekit/rtc-node-darwin-x64 Patch
@livekit/rtc-node-linux-arm64-gnu Patch
@livekit/rtc-node-linux-x64-gnu Patch
@livekit/rtc-node-win32-x64-msvc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidzhao
Copy link
Member Author

porting over @typester's fix on Python to Node.

packages/livekit-rtc/src/audio_source.ts Outdated Show resolved Hide resolved
@davidzhao davidzhao merged commit 69bde5e into main Dec 29, 2024
14 checks passed
@davidzhao davidzhao deleted the dispose-source branch December 29, 2024 03:23
@github-actions github-actions bot mentioned this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants