Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support node v18 #348

Closed
wants to merge 1 commit into from
Closed

support node v18 #348

wants to merge 1 commit into from

Conversation

lalitkapoor
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: a0ad2ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

@lukasIO
Copy link
Contributor

lukasIO commented Nov 29, 2024

Hi!
see #155 for the reason v19 is the minimum

@lukasIO lukasIO closed this Nov 29, 2024
@lalitkapoor
Copy link
Contributor Author

Hey @lukasIO We're unfortunately not ready to upgrade to from 18 to 19+ just yet. What do you think of this as a solution?

Node v18 is still officially supported in a maintenance only mode for a while and it would be great to match the officially supported versions if possible. Thanks!

Arc 2024-11-29 12 12 01

@lukasIO
Copy link
Contributor

lukasIO commented Nov 30, 2024

What do you think of this as a solution?

yeah, that could work!

@lalitkapoor
Copy link
Contributor Author

Great! I think if you reopen this PR, it should update to that commit. Will be good to include node v18 in the matrix of environments to tests.

@lukasIO
Copy link
Contributor

lukasIO commented Nov 30, 2024

Hm, Github doesn't allow me to reopen the PR. This might be related to some branching changes we recently made on the repo. Sorry about that! Could you open a new PR with the suggested changes?

@lalitkapoor
Copy link
Contributor Author

done - #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants