Add WHIP ICE Restart Support #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft. Should be tested against a client before worth reviewing |
|
Thanks for the review @biglittlebigben I will fix that up now! Here is a jsfiddle of how I was testing https://jsfiddle.net/phn51xz9/ |
Sean-Der
force-pushed
the
ice-restart
branch
4 times, most recently
from
894bba3
to
b9e0933
Compare
|
Ok I feel pretty good about that @biglittlebigben Testing with clients should happen Tuesday/Wednesday! |
Sean-Der
force-pushed
the
ice-restart
branch
2 times, most recently
from
85f9b4c
to
79f141a
Compare
biglittlebigben
approved these changes
May 14, 2024
|
Please let me know when you happy with your testing and this is ready to merge. |
|
@biglittlebigben testing went well, this is good for merge. I had to make one additional change though. We now close the session when goes to failed (30 seconds of no activity) instead of disconnected (5 seconds of no activity) The client side is waiting for 'disconnected'. |
biglittlebigben
added a commit
that referenced
this pull request
May 20, 2024
## Changelog ### Added - Add WHIP ICE Restart Support (#267)
Merged
biglittlebigben
added a commit
that referenced
this pull request
May 21, 2024
## Changelog ### Added - Add WHIP ICE Restart Support (#267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.