Improve track acquiring and handling in usePreviewTracks #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f0ebc4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…ekit/components-js into lukas/improve-preview-track-handling
davidzhao
approved these changes
Apr 17, 2024
packages/react/src/utils.ts
Outdated
| @@ -71,3 +71,38 @@ export function useForwardedRef<T extends HTMLElement>(ref: React.ForwardedRef<T | |||
|
|
|||
| return innerRef; | |||
| } | |||
|
|
|||
| export class Mutex { | |||
There was a problem hiding this comment.
should we export & use the version from client-sdk-js?
There was a problem hiding this comment.
makes sense, livekit/client-sdk-js#1110
lukasIO
commented
Apr 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to mitigate
NotReadableErrorsby making sure we only ever perform onecreateLocalTracksrequest at a time.Users reported seeing errors on Windows when trying to acquire specific cameras, so this is an attempt to fix that.
depends on livekit/client-sdk-js#1110 being released