Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startVideo method and RoomEvent.VideoPlaybackStatusChanged #939

Merged
merged 8 commits into from
Nov 17, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Nov 16, 2023

This is useful to show a play button when auto playing of videos has been blocked by the browser.
Currently this is the case on Safari in low power mode.

Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: 293f442

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 16, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 77.46 KB (+0.38% 🔺)
dist/livekit-client.umd.js 83.01 KB (+0.38% 🔺)

@lukasIO lukasIO requested a review from davidzhao November 16, 2023 12:17
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! gotta love these Safari quirks /s

@lukasIO lukasIO merged commit 7ad002d into main Nov 17, 2023
2 checks passed
@lukasIO lukasIO deleted the lukas/video-play-fail branch November 17, 2023 17:16
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants