-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner interface to default publish & capture settings #58
Conversation
@@ -9,9 +9,6 @@ export default class DeviceManager { | |||
'videoinput', | |||
]; | |||
|
|||
// kind => deviceId | |||
defaultDevices: Map<MediaDeviceKind, string> = new Map(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this now supposed to be maintained in the app like the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes for now, until we allow rooms to be created before connect. then it'll be room.defaultPublishOptions.audioDeviceId, etc.
src/room/track/LocalTrack.ts
Outdated
/* @ts-ignore */ | ||
noiseSuppression: true, | ||
noiseSuppression: defaults.echoCancellation, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaults.noiseSuppression
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoot! great catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Looks like there was one typo in assigning noiseSuppression
.
also fixes #57