handle explicit remote unmute, removed mute status match #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I should be able to test this tomorrow, but it'll be later in the day before I'll get the chance. |
great! give it a shot. The looping behavior went away in my tests. |
|
|
bekriebel
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
I'm only okay at the interface between this and the golang server, so I can't speak to the code quality. However, I tested this with my "mute loop" tests for #38 using my client implementation and it appears to fix my issue. Thanks!
bekriebel
added a commit
to bekriebel/fvtt-module-avclient-livekit
that referenced
this pull request
Sep 3, 2021
Pulls in changes: livekit/client-sdk-js#40 to fix :livekit/client-sdk-js#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #38