fix: handle server url with params correctly #1366
Open
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24845bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
jiyeyuran
force-pushed
the
fix-url_with_params
branch
from
f366e35 to
802996d
Compare
Change-Id: Icc11fab672200138ab11367671adc7565aa37a8a
jiyeyuran
force-pushed
the
fix-url_with_params
branch
from
802996d to
d313355
Compare
lukasIO
reviewed
Jan 10, 2025
src/api/SignalClient.ts
Outdated
| @@ -294,11 +298,11 @@ export class SignalClient { | |||
| abortHandler(); | |||
| } | |||
| abortSignal?.addEventListener('abort', abortHandler); | |||
| this.log.debug(`connecting to ${url + params}`, this.logContext); | |||
| this.log.debug(`connecting to ${urlObj}`, this.logContext); | |||
There was a problem hiding this comment.
Suggested change
| this.log.debug(`connecting to ${urlObj}`, this.logContext); | |
| this.log.debug(`connecting to ${urlObj.host}`, { | |
| reconnect: opts.reconnect, | |
| reconnectReason: opts.reconnectReason, | |
| ...this.logContext, | |
| }); |
Change-Id: I4d6390be6deec8bc9037af515d172456ec257eee
jiyeyuran
force-pushed
the
fix-url_with_params
branch
from
8ceadbd to
24845bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Id7c37483cf36acb15d662de82f0ddb6fc08f53b1