Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force playback after app visibility changes back to visible #1106

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Apr 15, 2024

On Safari sometimes the video element failed to auto play again after the browser came back from being in the background.
In order to work around this, we force play to be called on all attached elements once the app comes back into the foreground.

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 4761684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 15, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 83.34 KB (+0.03% 🔺)
dist/livekit-client.umd.js 88.9 KB (+0.03% 🔺)

@lukasIO lukasIO requested a review from davidzhao April 15, 2024 16:14
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

lukasIO added 2 commits April 15, 2024 18:15
…vekit/client-sdk-js into lukas/force-play-after-visible-change
@lukasIO lukasIO merged commit 7f0c1af into main Apr 15, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/force-play-after-visible-change branch April 15, 2024 16:17
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants