Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote facingMode logs to trace #1065

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Demote facingMode logs to trace #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b46b3ac
Demote facingMode logs to trace
lukasIO Mar 6, 2024
cd6af48
Create swift-peaches-compare.md
lukasIO Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-peaches-compare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-client": patch
---

Demote facingMode logs to trace
4 changes: 2 additions & 2 deletions src/room/track/facingMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ export function facingModeFromLocalTrack(
// 1. Try to get facingMode from track settings.
if ('facingMode' in trackSettings) {
const rawFacingMode = trackSettings.facingMode;
log.debug('rawFacingMode', { rawFacingMode });
log.trace('rawFacingMode', { rawFacingMode });
if (rawFacingMode && typeof rawFacingMode === 'string' && isFacingModeValue(rawFacingMode)) {
result = { facingMode: rawFacingMode, confidence: 'high' };
}
}

// 2. If we don't have a high confidence we try to get the facing mode from the device label.
if (['low', 'medium'].includes(result.confidence)) {
log.debug(`Try to get facing mode from device label: (${track.label})`);
log.trace(`Try to get facing mode from device label: (${track.label})`);
const labelAnalysisResult = facingModeFromDeviceLabel(track.label);
if (labelAnalysisResult !== undefined) {
result = labelAnalysisResult;
Expand Down
Loading