Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VideoPreset overload to not compute video aspectRatio by default #1044

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Feb 22, 2024

  • adds a new overload for VideoPreset that takes a videoPresetOptions object with optional aspectRatio parameter.
  • does not change the old behaviour of auto computing an aspect ratio if the old constructor is used

@lukasIO lukasIO requested a review from davidzhao February 22, 2024 16:46
Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 484cac7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 22, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 81.41 KB (+0.09% 🔺)
dist/livekit-client.umd.js 87.1 KB (+0.09% 🔺)

@lukasIO lukasIO changed the title Don't compute video aspectRatio by default on presets Add VideoPreset overload to not compute video aspectRatio by default Feb 22, 2024
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@lukasIO lukasIO merged commit 9f72b5e into main Feb 26, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/no-default-aspect branch February 26, 2024 12:29
@github-actions github-actions bot mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants