Remove googConstraints from RTCPeerConnection constructor

[lukasIO]

These constraints have been deprecated in Chromium since M103 and should be simply ignored by Chrome since then.
Users reported errors however (coincidentally with Chrome 103) with the error message Failed to construct 'RTCPeerConnection': Malformed constraints object. Was not able to repro this error using Chrome 103.

Given that this constraint was only ever used for enabling setting local network priority and has been ignored in Chrome for a long time, it seems like it should be ok to remove it entirely and therefore reducing error potential. Removing it will mean manually setting networkPriority will not have any effect on Chrome prior to version 103.

Alternative would be to try/catch RTCPeerConnection instantiation.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1f6ffbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
livekit-client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/livekit-client.esm.mjs	80.99 KB (-0.08% 🔽)
dist/livekit-client.umd.js	86.58 KB (-0.09% 🔽)

[davidzhao]

lgtm. agreed this is safer from a compatibility standpoint

[HermanBilous]

It seems to me that the issue might not have been in passing of deprecated googConstraints, but because of this line:

this.subscriber = new PCTransport(rtcConfig, loggerOptions);

Which should really have been

this.subscriber = new PCTransport(rtcConfig, undefined, loggerOptions);

Otherwise loggerOptions are passed as media constraints. The type for mediaConstraints is wide enough to support that, so ts error is not thrown.

[lukasIO]

that's a good catch! that might have been the issue. Thanks for pointing that out.
Don't see a need to revert the removal of the googConstraints though. Do you have a usecase that depends on them?

[HermanBilous]

Nah, I'm sure we don't rely on googConstraints, but I still think that going without removal of media constraints is the best option, since we would be able to fix the bug with minimal testing effort. Thanks for fixing it in v1!